Merged
Conversation
DN6
reviewed
Mar 25, 2026
| pip install -U torch --index-url https://download.pytorch.org/whl/cpu | ||
|
|
||
| - name: Build the dist files | ||
| run: python setup.py bdist_wheel && python setup.py sdist |
Collaborator
There was a problem hiding this comment.
Small nit. Running commands like this with setup.py is deprecated in favour of just running a single
python -m build which gives you both the sdist and the wheel
https://setuptools.pypa.io/en/latest/deprecated/commands.html#running-setuptools-commands
Think we can just use that here.
Member
Author
|
@DN6 a gentle ping. |
DN6
reviewed
Apr 22, 2026
github-actions
Bot
added
size/M
github-actions
Bot
added
size/M
github-actions
Bot
added
size/M
github-actions
Bot
added
size/M
github-actions
Bot
added
size/M
github-actions
Bot
added
size/M
Member
Author
|
@DN6 all your comments should have been addressed. Check now. |
DN6
approved these changes
Apr 23, 2026
| name: python-dist | ||
| path: dist/ | ||
|
|
||
| - name: Publish package distributions to TestPyPI |
Collaborator
There was a problem hiding this comment.
Suggested change
| - name: Publish package distributions to TestPyPI | |
| - name: Publish package distributions to PyPI |
| - "*" | ||
| - v* | ||
| branches: | ||
| - 'v*-release' |
Collaborator
There was a problem hiding this comment.
Just realised we use v*-patch for patch branch names. Not a merge blocker, I would actually prefer it if we just called everything v*-release like transformers moving forward.
github-actions
Bot
added
size/M
Member
Author
|
Failing tests are so unrelated! |
terarachang
pushed a commit
to terarachang/diffusers
that referenced
this pull request
Apr 30, 2026
* simplify release workflow. * up * trigger on branches too. * restrict permissions to read. * use sha * remove determination step of latest branch * resolve rest
ghostxsl
pushed a commit
to ghostxsl/diffusers
that referenced
this pull request
May 6, 2026
* simplify release workflow. * up * trigger on branches too. * restrict permissions to read. * use sha * remove determination step of latest branch * resolve rest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplify release workflow like https://github.com/huggingface/transformers/blob/main/.github/workflows/release.yml.
build-and-test(find release branch, build, install from wheel, run import tests) ->publish-to-pypi(download artifacts, publish).pypi-releasewith required reviewers — publishing pauses until a maintainer approves.pypa/gh-action-pypi-publish— replaces Twine username/password secrets.::set-output— no longer needed since branch resolution happens in the same job.I have taken care of the following config setups to make it work:
pypi-releasewith required reviewers (Dhruv, Yiyi, and myself).huggingface/diffusersrepo, specifying thepypi-releaseenvironment.